Create pre-release when release PR labelled as 'autorelease: pre-rele… #10
Conversation
|
@RobertCraigie I went with |
dgellow
force-pushed
the
sam/sta-2050-customers-should-have-way-to-mark-a-release-as-pre-release
branch
from
d6bf21e to
f339900
Compare
dgellow
requested review from
RobertCraigie
and removed request for
RobertCraigie
dgellow
force-pushed
the
sam/sta-2050-customers-should-have-way-to-mark-a-release-as-pre-release
branch
from
f339900 to
ededd04
Compare
| return labels.data.map(l => l.name); | ||
| } | ||
|
|
||
| async createLabels(labels: string[]) { |
There was a problem hiding this comment.
question: what permissions are needed for this to work?
There was a problem hiding this comment.
Good question, I need to check...
There was a problem hiding this comment.
It seems to be both "Issues" and/or "Pull Requests": https://docs.github.com/en/rest/overview/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28#repository-permissions-for-pull-requests. So we should be good.
There was a problem hiding this comment.
Great! Can you double check with a test repo just to make sure? (I'm fairly paranoid about GitHub doing weird things)
There was a problem hiding this comment.
You're right, I will double check, I don't want to break the whole CI
There was a problem hiding this comment.
I can confirm, that seems to work with only Pull Request or only Issues as writeable :)
dgellow
force-pushed
the
sam/sta-2050-customers-should-have-way-to-mark-a-release-as-pre-release
branch
from
ca37f76 to
1df72dc
Compare
dgellow
deleted the
sam/sta-2050-customers-should-have-way-to-mark-a-release-as-pre-release
branch
This pull request adds a concept of "pre-release labels" that can be used on a release PR to denotate that the github release should be created as a pre-release. The label
autorelease: pre-releaseis added directly byrelease-pleasewhen creating the PR if a pre-release is detected, but can also be added by users before merging the pull request.In addition, to ensure labels can be selected by users via the "Labels dropdown" from GitHub UI, all labels are now created for the repository if they don't exist yet, before creating a pull request.